Merging from upstream #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCloud SDK auto-installer
Workflow plugin compatibility
new version of google-oauth-plugin and fix gcloud path
Allows for using in declarative pipeline "tools" block.
getSDK() was previously changed to scan all installations to find the one that matches the selected installation. But when "(Default)" is selected, `installation` is an empty string, and none of the installed installations will match that. So when (Default) was selected, just look for the first available installation.
The default credential selection ("-none-") implies that there should be no
authentication performed. Normally this would be unusual because most gcloud
commands will require auth (but not all!).
Since there is also the option to execute a gcloud command with auth, that
also gives another chance to select a different service account. And if the
gcloud command does require auth, it will fail with:
ERROR: (gcloud.the.command.that.ran)
You do not currently have an active account selected.
which should be sufficient to indicate that they need to select credentials.
As of v0.8, the key is no longer exposed as a JSON file, but instead it only exposes the accountId and privateKey. In order to use the key with the gcloud SDK, we need to be able to pass the path to a JSON file.
Explicitly depend on http-client-jackson2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.