feat(AddTask): Add entry date field to Add Task dialog #267
Conversation
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
ShivaGupta-14
force-pushed
the
feat/188-add-entry-to-addTask
branch
from
5b462b9 to
bd5cbd7
Compare
|
Hi @its-me-abhishek! I noticed that the |
|
Will look into this @ShivaGupta-14 |
|
@its-me-abhishek, I’ve already completed the self-review and added it to the PR. |
ShivaGupta-14
force-pushed
the
feat/188-add-entry-to-addTask
branch
5 times, most recently
from
88cfeda to
a12b4de
Compare
There was a problem hiding this comment.
extract entryDate from request body and passed it to the function
There was a problem hiding this comment.
added the entry field to this struct to accept it from frontend
There was a problem hiding this comment.
update the function to accept entrydate parameter
There was a problem hiding this comment.
added new test cases for entry field
There was a problem hiding this comment.
added entry field to new task state and pass it to addTaskToBackend when submitting, and after submission, reset it.
There was a problem hiding this comment.
added entry field to addTaskToBackend function parameter, type definition and request body.
There was a problem hiding this comment.
added entry-date ui
ShivaGupta-14
left a comment
ShivaGupta-14
left a comment
There was a problem hiding this comment.
self review completed!, open to any suggestions or feedback.
ShivaGupta-14
force-pushed
the
feat/188-add-entry-to-addTask
branch
from
a12b4de to
1329c43
Compare
Hi @its-me-abhishek! This is also ready for review. I just wanted to confirm one thing, what would you prefer we do with this function? Should we move to a dynamic mock for clearer test logic, or keep it as it is? |
|
Should be fixed imo |
- Add entry date field to backend request body and Taskwarrior CLI - Implement entry date picker in AddTaskDialog frontend component - Update type definitions and hooks to support entry field - Add comprehensive frontend and backend tests for the new field Issue: CCExtractor#188
ShivaGupta-14
force-pushed
the
feat/188-add-entry-to-addTask
branch
from
1329c43 to
bf6f416
Compare
|
Hi @its-me-abhishek! Done!, Now this PR is also completely ready for review. |
| import { AddTaskdialog } from '../AddTaskDialog'; | ||
| import '@testing-library/jest-dom'; | ||
|
|
||
| jest.mock('date-fns', () => ({ |
There was a problem hiding this comment.
changed date-fns mock from static to dynamic, now returns the actual formatted date based on input.
|
Thanks for merging :) |
2 participants
Add Entry Date Field to Add Task Dialog
Description
Implemented the
entrydate field in the Add Task dialog, allowing users to specify the entry date when creating a new task.Previously, the
entryfield could only be set via the CLI tool. This change makes it accessible directly from the UI while keeping it completely optional.Updates: #188
Checklist
npx prettier --write .(for formatting)gofmt -w .(for Go backend)npm test(for JS/TS testing)Additional Notes
Self-Review
I've reviewed my changes and confirm:
entryfield is completely optional; leaving it empty causes no errors.Screenshots
Add Task Dialog with Entry Field:
Video:
Screen.Recording.2025-12-11.at.7.02.19.PM.mov