Merged
Conversation
…ce in Python: - Removed LITTLE_ENN and BIG_ENN constants - No need to make any other changes as there is no reference of this anywhere else in the codebase
jimboid
approved these changes
Mar 20, 2025
Member
jimboid
left a comment
jimboid
left a comment
There was a problem hiding this comment.
Happy with this if it is not used. It was probably copy and pasted from old code. I've only ever seen endian issues with NAMD input files, I would hope MDAnalysis would handle it properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR will remove Endian Sensitive Math as this is not a modern Python approach to follow.
Changes
Removal of Constants:
LITTLE_ENNandBIG_ENNconstantsImpact