Merged
Conversation
- top_traj_file had a default value which meant it overided the merging of YAML and CLI - Removed the default value - Fixed tests to account for this change
…74-yaml-input-bug
Member
|
@harryswift01 Have you added a check that gives a warning if anyone tries to add a new argument with a default of [] or "" or similar, so we don't get a repeat of this bug? |
jimboid
approved these changes
Mar 25, 2025
Member
jimboid
left a comment
jimboid
left a comment
There was a problem hiding this comment.
Looks good. Test is present to check for badly defined defaults to avoid the odd pythonic behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the argument handling for top_traj_file to remove its default value, ensuring proper merging of YAML and CLI inputs.
Changes
top_traj_fileargument handling:Impact