Skip to content

Develop#61

Merged
jirivrany merged 15 commits intomainfrom
develop
Jul 4, 2025
Merged

Develop#61
jirivrany merged 15 commits intomainfrom
develop

Conversation

@jirivrany
Copy link
Collaborator

version 1.1.2 with minor bug fixes and improved security (removed unused JS files)

@jirivrany jirivrany requested a review from Copilot July 3, 2025 09:32

This comment was marked as outdated.

jirivrany and others added 4 commits July 3, 2025 15:32
exec is generally considered insecure and may trigger more security warnings in the future

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Update to use pyproject.toml
@jirivrany jirivrany requested a review from Copilot July 3, 2025 14:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades to version 1.1.2 by removing unused JavaScript assets, migrating to a pyproject.toml–based build, cleaning up debug statements, and enhancing type safety in API views.

  • Removed legacy setup.py and requirements-backup.txt in favor of pyproject.toml
  • Deleted unused JS files under static/js and cleaned debug print calls
  • Added type annotations in flowapp/views/api_common.py and updated configuration keys for rule limits

Reviewed Changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated no comments.

Show a summary per file
File Description
setup.py Deleted legacy setuptools script
requirements-backup.txt Deleted outdated requirements backup
pyproject.toml Introduced modern build config and dependency declarations
flowapp/views/*.py Removed debug prints; added type hints in api_common.py
flowapp/models/utils.py Split FLOWSPEC_MAX_RULES into FLOWSPEC4/FLOWSPEC6 limits
flowapp/views/admin.py & templates/pages/orgs.html Updated limit variables and template references
flowapp/templates/layouts/default.html Bumped Bootstrap to 5.3.3
flowapp/static/js/* Removed unused JS sources
README.md Bumped version and updated changelog entry
.github/workflows/python-app.yml Switched CI to install editable package with dev deps
Comments suppressed due to low confidence (5)

README.md:62

  • The changelog entry mentions setup.py reading dependencies, but setup.py was removed and dependency management now uses pyproject.toml. Please update this line to accurately reflect the migration to pyproject.toml.
- 1.1.2 - minor security updates (removed unused JS files), setup.py now reads dependencies from requirements.txt

flowapp/views/api_common.py:63

  • There's a typo in the docstring: 'loged' should be 'logged'.
    Generate API Key for the logged user using PyJWT

flowapp/views/api_common.py:166

  • The signature declares a return type of Tuple[Response, int], but the successful branch returns just jsonify(actions) (Response only). Consider adding an explicit status code or adjusting the annotation.
def all_actions(current_user: Dict[str, Any]) -> Tuple[Response, int]:

flowapp/views/api_common.py:180

  • Similar to all_actions, this function is annotated to return a Tuple but the success path omits an explicit status code. Align the implementation with its annotation.
def all_communities(current_user: Dict[str, Any]) -> Tuple[Response, int]:

flowapp/views/api_common.py:393

  • [nitpick] The variable prefered_tf is misspelled; consider renaming it to preferred_tf for clarity and consistency.
    prefered_tf: str = request.args.get(TIME_FORMAT_ARG) if request.args.get(TIME_FORMAT_ARG) else ""

@jirivrany jirivrany merged commit 416d8e4 into main Jul 4, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant