Skip to content

Develop#63

Merged
jirivrany merged 2 commits intomainfrom
develop
Jul 14, 2025
Merged

Develop#63
jirivrany merged 2 commits intomainfrom
develop

Conversation

@jirivrany
Copy link
Collaborator

No description provided.

@jirivrany jirivrany requested a review from Copilot July 14, 2025 11:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the project version to 1.1.3, removes debugging prints from the admin update routine, and adds a configurable footer menu to the default template.

  • Remove debug print statements in update_set_org
  • Introduce a new inject_footer_menu context processor and render footer_menu in the base layout
  • Bump application version to 1.1.3 and update CHANGELOG

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
flowapp/views/admin.py Removed debug print statements from the update_set_org function
flowapp/utils/app_factory.py Added inject_footer_menu context processor for footer menu configuration
flowapp/templates/layouts/default.html Updated layout to include a <footer> rendering dynamic footer_menu and version
flowapp/about.py Bumped __version__ to 1.1.3
README.md Updated CHANGELOG entry for version 1.1.3
Comments suppressed due to low confidence (3)

flowapp/views/admin.py:674

  • Consider using the application logger (e.g., logger.debug) instead of print statements for debug output so it can be properly managed and filtered in production.
        data_records = model.query.filter(model.org_id == 0).all()

flowapp/views/admin.py:684

  • Consider using the application logger for diagnostic messages instead of print statements to maintain consistent logging practices.
            else:

flowapp/utils/app_factory.py:112

  • It would be helpful to add a unit test to verify that the footer_menu context processor correctly injects the FOOTER_MENU configuration into the template context.
    def inject_footer_menu():

<div class="container">
<div class="row justify-content-between align-items-center">
<div class="col-md-auto mb-2 mb-md-0">
<nav class="nav">
Copy link

Copilot AI Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding an aria-label (e.g., aria-label="Footer navigation") to the

element to improve accessibility for screen readers.

Suggested change
<nav class="nav">
<nav class="nav" aria-label="Footer navigation">

Copilot uses AI. Check for mistakes.


## Change Log
- 1.1.3 - introduced configurable footer menu for links in bottom of the default template
Copy link

Copilot AI Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider rephrasing to 'introduced configurable footer menu for links at the bottom of the default template' for improved readability.

Suggested change
- 1.1.3 - introduced configurable footer menu for links in bottom of the default template
- 1.1.3 - introduced configurable footer menu for links at the bottom of the default template

Copilot uses AI. Check for mistakes.
@jirivrany jirivrany merged commit 861cc3d into main Jul 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant