Project 5: Utkarsh Dwivedi#14
Open
utkarshdwivedi3997 wants to merge 31 commits intoCIS565-Fall-2023:mainfrom
Open
Project 5: Utkarsh Dwivedi#14utkarshdwivedi3997 wants to merge 31 commits intoCIS565-Fall-2023:mainfrom
utkarshdwivedi3997 wants to merge 31 commits intoCIS565-Fall-2023:mainfrom
Conversation
… for the 3 storage buffers)
…ove data from blades to culled blades in compute shader
…leading. This array contains blades that have NOT been culled and are going to be rendered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repo Link
Features:
Feedback: this was a fun project! The base code is generally really helpful, though the comments in shader code could be elaborated upon a little more. For people with no prior Vulkan experience it would have been nice to have gone over something like a Vulkan setup lab (similar to the performance lab we had in class), as only one week to learn Vulkan and implement the paper felt a little too less time.