Conversation
master to develop
Develop add timeout
SK2iP
approved these changes
Jan 2, 2025
Member
SK2iP
left a comment
SK2iP
left a comment
There was a problem hiding this comment.
Great work Tnx nader.
Just for my clarity why did you add rpc_timeout to thrift_client argument ? is it just for well-structured and maintains clarity of the project ?
Member
|
Additionally wouldn't be beneficial to use set_timeout function, to specify how long the client should wait for server answer? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.