Add cmake opencv 4 support#3
Open
ambersun1234 wants to merge 5 commits intoCMU-Perceptual-Computing-Lab:masterfrom
ambersun1234:master
Open
Add cmake opencv 4 support#3ambersun1234 wants to merge 5 commits intoCMU-Perceptual-Computing-Lab:masterfrom ambersun1234:master
ambersun1234 wants to merge 5 commits intoCMU-Perceptual-Computing-Lab:masterfrom
ambersun1234:master
Conversation
Member
|
OpenPose does not need Caffe with OpenCV, so this PR is not high priority for me to be involved on it. However, I would be happy to accept it if the following changes are made:
And then all other files should simply include this new header. (I also do this in OpenPose itself) With the 3 changes above i'll happily merge it! |
Signed-off-by: Gines Hidalgo <gineshidalgo99@gmail.com>
Author
|
@gineshidalgo99 All of the above issue had been corrected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add opencv4 support in cmake compilation process
opencv3 to 4 had changed some of the variable name
causing the compilation failed.
I've add some of the switch to overcome these kind of error
in
CMakeLists.txtfile, there is a option to enable build opencv4 or not