Skip to content

Conversation

@Zeitsperre
Copy link
Member

@Zeitsperre Zeitsperre commented Jul 24, 2025

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Updates the cookiecutter template to use newer dependencies and conventions
  • Drop black and isort (redundant via ruff)
  • Remove handling for obsolete owslib
  • Tests are now linted (less strictly)

Does this PR introduce a breaking change?

Somewhat. Code style conventions are different, but code is largely the same, barring a handful of small suggested changes.

Other information:

This probably doesn't require a minor release.

@Zeitsperre Zeitsperre requested review from huard and tlvu July 24, 2025 22:20
@Zeitsperre Zeitsperre self-assigned this Jul 24, 2025
@github-actions
Copy link

Note

It appears that this Pull Request modifies the main.yml workflow.

On inspection, the RAVEN_TESTDATA_BRANCH environment variable is set to the most recent tag (v2025.6.12).

No further action is required.

@tlvu
Copy link
Collaborator

tlvu commented Jul 25, 2025

Not sure I can review this. I don't know this repo well enough. I can rubber stamp if you are blocked and need this one in, if that is your intention.

@Zeitsperre
Copy link
Member Author

Not needed. It would be good to get an actual review on this. There's still one strange error happening, but I hope it isn't something broken upstream.

Base automatically changed from fix-notebooks to master August 1, 2025 17:01
@coveralls
Copy link

coveralls commented Aug 1, 2025

Coverage Status

coverage: 80.779% (+0.03%) from 80.752%
when pulling 01cb0b5 on update-cookiecutter
into 74093f3 on master.

Zeitsperre and others added 2 commits August 5, 2025 15:31
Co-authored-by: David Huard <huard.david@ouranos.ca>
@Zeitsperre Zeitsperre merged commit 5c59d0a into master Aug 5, 2025
19 checks passed
@Zeitsperre Zeitsperre deleted the update-cookiecutter branch August 5, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants