Skip to content

Fix a fencepost / off-by-one error #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eric-wieser wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix a fencepost / off-by-one error #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7f95b0
Fix a fencepost / off-by-one error
eric-wieser Oct 11, 2021
66f455f
Add a comment
eric-wieser Oct 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions 01-ExamplesPaper1-Field-Lines.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,25 +123,26 @@
" N = 100\n",
" ds = float(distance) / N\n",
" \n",
" X = np.zeros(N)\n",
" Y = np.zeros(N)\n",
" Z = np.zeros(N)\n",
" # To create N line segments, we need N+1 points",
" X = np.zeros(N+1)\n",
" Y = np.zeros(N+1)\n",
" Z = np.zeros(N+1)\n",
" \n",
" X[0] = x0\n",
" Y[0] = y0\n",
" Z[0] = z0\n",
" \n",
" for i in range(1,N):\n",
" [Bx,By,Bz] = myfield( X[i-1], Y[i-1], Z[i-1] ) # Evaluate the field at the previous point (i-1)\n",
" for i in range(N):\n",
" [Bx,By,Bz] = myfield( X[i], Y[i], Z[i] ) # Evaluate the field at the previous point i\n",
" # Normalise the vector:\n",
" magnitude = np.sqrt( Bx**2 + By**2 + Bz**2 )\n",
" Bnx = Bx / magnitude\n",
" Bny = # insert your code\n",
" Bnz = # insert your code\n",
" # Now evaluate the field line location at the current point (i)\n",
" X[i] = X[i-1] + Bnx*ds\n",
" Y[i] = # insert your code\n",
" Z[i] = # insert your code\n",
" # Now evaluate the field line location at the current point (i+1)\n",
" X[i+1] = X[i] + Bnx*ds\n",
" Y[i+1] = # insert your code\n",
" Z[i+1] = # insert your code\n",
" \n",
" return X, Y, Z # Return the coordinates of the field line"
]
Expand Down