add test cases

Author: onlyjackfrost

packages/extension-driver-canner/src/lib/cannerDataSource.ts

@@ -170,12 +170,7 @@ export class CannerDataSource extends DataSource<any, PGOptions> {
     const userPoolKey = this.getUserPoolKey(password, database);
     if (this.UserPool.has(userPoolKey)) {
       const userPool = this.UserPool.get(userPoolKey);
-      if (!userPool) {
-        throw new InternalError(
-          `User pool ${userPoolKey} is not a Pool instance`
-        );
-      }
-      return userPool;
+      return userPool!;
     }
     const pool = new Pool({ ...poolOptions, password: password });
     this.UserPool.set(userPoolKey, pool);

packages/extension-driver-canner/test/cannerDataSource.spec.ts

@@ -348,7 +348,7 @@ it('Should return the same pool when the profile and authentication is the same'
   expect(pool1 === pool2).toBeTruthy();
 }, 30000);
 
-it('Should return different pool if authentication exist in headers even the profile is the same', async () => {
+it('Should return new user pool if user pool not exist', async () => {
   // Arrange
   mockDataSource = new MockCannerDataSource({}, '', [
     pg.getProfile('profile1'),
@@ -373,3 +373,27 @@ it('Should return different pool with different authentication even the profile
   // Assert
   expect(pool1 === pool2).toBeFalsy();
 }, 30000);
+
+it('Should throw error when the profile is not exist', async () => {
+  // Arrange
+  mockDataSource = new MockCannerDataSource({}, '', [
+    pg.getProfile('profile1'),
+  ]);
+  await mockDataSource.activate();
+  // Act, Assert
+  expect(() => mockDataSource.getPool('profile2')).toThrow(
+    'Profile instance profile2 not found'
+  );
+}, 30000);
+
+it('Should return default pool when password was not given', async () => {
+  // Arrange
+  mockDataSource = new MockCannerDataSource({}, '', [
+    pg.getProfile('profile1'),
+  ]);
+  await mockDataSource.activate();
+  // Act
+  const pool = mockDataSource.getPool('profile1');
+  // Assert
+  expect(pool).toBeDefined();
+}, 30000);

packages/extension-driver-canner/test/mock/mockCannerDataSource.ts

@@ -16,12 +16,7 @@ export class MockCannerDataSource extends CannerDataSource {
     const userPoolKey = this.getUserPoolKey(password, database);
     if (this.UserPool.has(userPoolKey)) {
       const userPool = this.UserPool.get(userPoolKey);
-      if (!userPool) {
-        throw new InternalError(
-          `User pool ${userPoolKey} is not a Pool instance`
-        );
-      }
-      return userPool;
+      return userPool!;
     }
     const pool = new Pool({ ...poolOptions, password: password });
     this.UserPool.set(userPoolKey, pool);