pending trades(?) and historical data fetching

[sixtysixx]

honestly rust syntax is so confusing to me and half of this is AI lmfao so im not sure what exactly works or not

Summary by CodeRabbit

• New Features

  • Added historical data retrieval for trading assets
  • Added pending trades/orders functionality
  • Added asset validation for trading operations
  • Extended client with trade result checking capabilities

• Bug Fixes

  • Fixed module naming and import paths (spelling corrections)
  • Corrected error messaging

• Documentation

  • Expanded API reference with configuration parameters
  • Updated README with installation, usage examples, and feature status

• Refactor

  • Updated Rust edition compatibility (2024 → 2021)
  • Modernized TLS implementation
  • Improved CI/CD workflow structure

• Chores

  • Updated dependencies and build configuration
  • Reorganized project structure and test infrastructure

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[sixtysixx]

@coderabbitai summary

[coderabbitai]

✅ Actions performed

Summary regeneration triggered.

[gemini-code-assist]

Code Review

This pull request includes several changes, including downgrading the Rust edition from 2024 to 2021, removing the CI workflow file, adding a get_trade_history function and get_deal_end_time function, adding a HistoricalDataApiModule for handling historical data requests, adding a PendingTradesApiModule for handling pending trade orders, and adding various improvements and fixes. The code review comments highlight the critical issue of removing the CI workflow file, request confirmation on downgrading the Rust edition, suggest including message content in a warning message, and commend the logic for handling duplicate history requests and the robust error handling in get_server_datetime.

I am having trouble creating individual review comments. Click here to see my feedback.

BinaryOptionsToolsV2/.github/workflows/CI.yml (1-169)

The removal of the CI workflow file is a critical issue. Without automated testing and build processes, it becomes significantly harder to maintain code quality, catch regressions, and ensure the reliability of the project. This should be reinstated or replaced with an equivalent automated process.

BinaryOptionsToolsV2/Cargo.toml (4)

The Rust edition has been downgraded from 2024 to 2021. While 2021 is a stable edition, downgrading might indicate compatibility issues with other tools or dependencies that were not explicitly mentioned. Please ensure this change is intentional and doesn't introduce any limitations or prevent future upgrades to newer Rust features.

crates/binary_options_tools/Cargo.toml (4)

The Rust edition has been downgraded from 2024 to 2021. Please confirm this change is intentional and necessary, as it might limit the use of newer Rust language features or indicate compatibility constraints with other parts of the project or toolchain.

crates/binary_options_tools/src/pocketoption/modules/deals.rs (237-239)

The warning message Received unexpected binary message when no header was seen. is good for debugging. However, it might be beneficial to include the actual message content (or a truncated version) in the warning to provide more context when this occurs, helping to identify the source of unexpected messages.

crates/binary_options_tools/src/pocketoption/modules/subscriptions.rs (446-465)

The added logic to handle duplicate history requests and send a HistoryFailed response is a good improvement for robustness. It prevents the system from being overwhelmed by redundant requests and provides clear feedback to the caller.

crates/binary_options_tools/src/pocketoption/state.rs (198-206)

The added match statement for DateTime::from_timestamp in get_server_datetime provides more robust error handling. Instead of unwrap_or_else, it now logs a warning if the timestamp conversion fails and defaults to Utc::now(), which is a safer approach.

crates/binary_options_tools/src/pocketoption/utils.rs (58-66)

Using the IPIFY_URL constant and adding a match statement to handle the json["ip"].as_str() result improves robustness. It prevents an unwrap() call from panicking if the 'ip' field is missing or not a string, providing a more graceful error handling mechanism.

[sixtysixx]

@coderabbitai summary

[coderabbitai]

✅ Actions performed

Summary regeneration triggered.