Fix wheels #46
Fix wheels #46
Conversation
Summary of ChangesHello @theshadow76, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a minor formatting inconsistency by ensuring that a specific JavaScript example file ends with a newline character. This change improves code consistency and aligns with best practices for file termination, despite the generic title "Fix wheels" which doesn't directly reflect the content. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughCI/CD workflow configuration refined to streamline release automation. Artifact handling paths are adjusted for consistency, release job conditions simplified, and GitHub Release documentation enhanced with detailed installation notes and metadata. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a newline to the end of examples/javascript/create_raw_iterator.js, which is a good formatting fix. However, upon reviewing the file, I noticed that it appears to be a non-functional example. It explicitly states that the createRawIterator method is not implemented, which could be confusing for users. I recommend either removing this file or updating it to demonstrate a working feature to improve the quality of the examples.
There was a problem hiding this comment.
Pull request overview
Updates the CI release workflow to correctly collect and publish built wheel artifacts, and applies a small formatting fix in a JavaScript example.
Changes:
- Adjusts the
releasejob trigger conditions and changes artifact download location to a dedicatedwheels/directory. - Updates attestation and release upload globs to match the new artifact directory structure and adds a richer GitHub Release configuration/body.
- Fixes a minor formatting/line issue in the JavaScript
create_raw_iteratorexample.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
examples/javascript/create_raw_iterator.js |
Minor formatting/line correction at the script entrypoint invocation. |
.github/workflows/CI.yml |
Fixes wheel artifact collection pathing and updates the release/attestation/upload configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| pip install BinaryOptionsToolsV2-${{ github.ref_name }}-cp38-abi3-win_amd64.whl | ||
|
|
||
| # Linux (x86_64) | ||
| pip install BinaryOptionsToolsV2-${{ github.ref_name }}-cp38-abi3-manylinux_2_28_x86_64.whl | ||
|
|
||
| # macOS (Intel) | ||
| pip install BinaryOptionsToolsV2-${{ github.ref_name }}-cp38-abi3-macosx_10_12_x86_64.whl |
There was a problem hiding this comment.
The wheel filenames in these install examples likely double-prefix the version. github.ref_name for your tags appears to already be of the form BinaryOptionsToolsV2-0.x.y (see README.md installation URLs), so BinaryOptionsToolsV2-${{ github.ref_name }}-... would become BinaryOptionsToolsV2-BinaryOptionsToolsV2-0.x.y-... and not match the actual asset names. Consider using ${{ github.ref_name }} directly for the filename portion (or derive a separate version variable if your tag naming differs).
| pip install BinaryOptionsToolsV2-${{ github.ref_name }}-cp38-abi3-win_amd64.whl | |
| # Linux (x86_64) | |
| pip install BinaryOptionsToolsV2-${{ github.ref_name }}-cp38-abi3-manylinux_2_28_x86_64.whl | |
| # macOS (Intel) | |
| pip install BinaryOptionsToolsV2-${{ github.ref_name }}-cp38-abi3-macosx_10_12_x86_64.whl | |
| pip install ${{ github.ref_name }}-cp38-abi3-win_amd64.whl | |
| # Linux (x86_64) | |
| pip install ${{ github.ref_name }}-cp38-abi3-manylinux_2_28_x86_64.whl | |
| # macOS (Intel) | |
| pip install ${{ github.ref_name }}-cp38-abi3-macosx_10_12_x86_64.whl |
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.