Fixes the Text Changed String check #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think Objects.equals is better here |
brachy84
approved these changes
Nov 12, 2025
brachy84
pushed a commit
to brachy84/ModularUI2-GTNH
that referenced
this pull request
Nov 12, 2025
* Fixes the Text Changed String check * Change to use Objects.equals() (cherry picked from commit 1abacfa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports the Mixin from here: GregTechCEu/GregTech#2868 Which solves an issue that we found during updating MUI2 where the text would not be properly updated if the widget did not have text originally.
I went with an empty check for the new text, because as far as I could see all the text returned by
this.key.getFormatted()was non null.