Open
Conversation
Cotel
requested review from
Martrout96,
Starkie,
bytemines,
frnlpz,
josegarm,
pedrodaviddev,
srgtrujillo and
tonilopezmr
bytemines
reviewed
May 1, 2017
|
|
||
| val memento = originator.saveToMemento() | ||
|
|
||
| assert.that(memento.state, `is`(memento.state)) |
Collaborator
There was a problem hiding this comment.
In this case this method will always be true, isn't it. Because here you are comparing memento state with the same memento state, not with the originator. 🤔
Cotel
commented
May 1, 2017
| } | ||
|
|
||
| fun getMemento(index: Int) : Memento<T>? = mementoList[index] | ||
| } |
Member
Author
There was a problem hiding this comment.
Is this really the best way to do this in Kotlin? I see little sense in wrapping a mutable list 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #20
I think this pattern has no sense in Kotlin. We could join
OriginatorandMementoand we could makeCareTakerdissappear because it is only a wrapper of a List of Mementos. Memento has a immutable state and if you want to modify it's state you would create a new Memento with another state and store them in a List in case you want to get back to some of them.What do you think?