Open
Conversation
Cotel
reviewed
May 7, 2017
|
|
||
| class Roulette{ | ||
|
|
||
| var observer: CategoryObserver? = null |
Member
There was a problem hiding this comment.
There is no need to create a separated object in this case. I think it is more natural if Players are observing the Roulette directly 👍
Cotel
reviewed
May 7, 2017
| package oop.Observer2 | ||
|
|
||
|
|
||
| data class Player (val name: String, |
Member
There was a problem hiding this comment.
The Player is the observer. The Roulette is observable.
Cotel
reviewed
May 7, 2017
| package oop.Observer2 | ||
|
|
||
| interface Observer<T>{ | ||
| val list: MutableList<Player> |
Member
There was a problem hiding this comment.
Why must an Observer have a list of Players? This is an unnecessary coupling 😅
Cotel
requested changes
May 7, 2017
Member
Cotel
left a comment
Cotel
left a comment
There was a problem hiding this comment.
This approach is really illustrative. Even more than my previous example I think. Maybe we should change it in the README 🤔
Write some tests before merging please 🙏
Member
Author
|
Now it's much clearer! Thx @Cotel I'm writing some tests between this evening and tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's another example of observer pattern. In this case, the goal is to notify players in a game of roulette of changes in the category picked after the wheel has spinned.