Convert unit test assertion helpers into macros#4009

Open

nrwahl2 wants to merge 49 commits intoClusterLabs:mainfrom

nrwahl2:nrwahl2-unit_test

Commits on Dec 20, 2025

Refactor: libcrmcommon: Best practices in output unit tests
nrwahl2
committed
Refactor: libcrmcommon: Reduce duplication for mk_fake_test_output()
nrwahl2
committed
Refactor: libcrmcommon: pcmk__output_new test uses common make function
nrwahl2
committed
Refactor: libcrmcommon: pcmk__output_free test uses common make function
nrwahl2
committed
Refactor: libcrmcommon: Common make func in output_and_clear_error test
nrwahl2
committed
Refactor: libcrmcommon: Group setup/teardown functions in output tests
nrwahl2
committed
Refactor: libcrmcommon: Reduce output test setup/teardown duplication
nrwahl2
committed
Refactor: libcrmcommon: Reduce duplication of null output create funcs
nrwahl2
committed
Refactor: libcrmcommon: Reduce duplication of null output message funcs
nrwahl2
committed
Refactor: libcrmcommon: Don't allocate object in pcmk__output_factory_t
nrwahl2
committed
Refactor: libcrmcommon: Make pcmk__call_message() static
nrwahl2
committed
Refactor: libcrmcommon: Make pcmk__register_message() library-private
nrwahl2
committed
Refactor: libcrmcommon: Drop pcmk__output_t:register_message()
nrwahl2
committed
Refactor: libcrmcommon: pcmk__quote_cmdline() takes const char *const *
nrwahl2
committed
Refactor: libcrmcommon: pcmk__bare_output_new takes const char *const *
nrwahl2
committed
Refactor: libcrmcommon: pcmk__output_new() takes const char *const *
nrwahl2
committed
Low: libcrmcommon: Avoid memory leak in assert_hr_format()
nrwahl2
committed
Refactor: libcrmcommon: New assert_hr_format_usec()
nrwahl2
committed
Refactor: libcrmcommon: Drop usec arg from assert_hr_format()
nrwahl2
committed
Refactor: libcrmcommon: Drop NULL-check of expected in assert_hr_format
nrwahl2
committed
Refactor: libcrmcommon: New assert_hr_format_alt()
nrwahl2
committed
Refactor: libcrmcommon: Drop assert_lookup_user() name argument
nrwahl2
committed
Refactor: libcrmcommon: Reduce duplication in pcmk__lookup_user() test
nrwahl2
committed
Refactor: libcrmcommon: Move will_return() calls to assert_lookup_user()
nrwahl2
committed
Refactor: libcrmcommon: Drop assert_lookup_user() uid/gid arguments
nrwahl2
committed
Refactor: libcrmcommon: New assert_lookup_user_one()
nrwahl2
committed
Refactor: libcrmcommon: Test pcmk__compare_versions() bidirectionally
nrwahl2
committed
Refactor: libcrmcommon: Rename assert_compare_version()
nrwahl2
committed
Refactor: libcrmcommon: Split unit test helper into success/fail cases
nrwahl2
committed
Refactor: libcrmcommon: Split part of assert_comment() into macro helper
nrwahl2
committed
Refactor: libcrmcommon: Split unit test helpers into NULL/non-NULL cases
nrwahl2
committed
Refactor: libcrmcommon: Split unit test helpers into true/false cases
nrwahl2
committed
Refactor: libcrmcommon: Split out unit tests for 0xD800 to 0xDFFF
nrwahl2
committed
Refactor: libcrmcommon: Use constant in pcmk__xe_get_score() test
nrwahl2
committed
Refactor: libcrmcommon: Use constant in pcmk__xe_set_score() test
nrwahl2
committed
Refactor: libcrmcommon: Shorten test names for pcmk__xe_set_score()
nrwahl2
committed
Refactor: libcrmcommon: Functionize table creation in assert_deref()
nrwahl2
committed
Refactor: libcrmcommon: Use TEST_ATTR constant in deref test
nrwahl2
committed
Refactor: libcrmcommon: Use TEST_ELEMENT constant in deref test
nrwahl2
committed
Low: libcrmcommon: Avoid memory leak in deref test
nrwahl2
committed
Refactor: libcrmcommon: Ensure xml_string is non-NULL in deref test
nrwahl2
committed
Refactor: libcrmcommon: Unindent block in deref test
nrwahl2
committed
Refactor: libcrmcommon: Simplify assert_submatch()
nrwahl2
committed
Low: libcrmcommon: Convert unit test assertion helpers to macros
nrwahl2
committed
Refactor: fencer: NULL-check device at start of localhost_is_eligible()
nrwahl2
committed
Refactor: libcrmcommon: pcmk__g_strv_contains() takes double-const arg
nrwahl2
committed
Refactor: libpacemaker: pcmk__check_rules() takes const char *const *
nrwahl2
committed
Refactor: tools: Use const char *const * in cibsecret.c or rsh_fn/rcp_fn
nrwahl2
committed
Refactor: various: Use const char *const * where possible
nrwahl2
committed