Skip to content

fix(velocity): split onLoad and onEnable calls to late/early ProxyInitializeEvent handlers #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CodeCrafter47 merged 1 commit into from
Mar 25, 2025
Merged

fix(velocity): split onLoad and onEnable calls to late/early ProxyInitializeEvent handlers #767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions bootstrap-velocity/src/main/java/codecrafter47/bungeetablistplus/BootstrapPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

import codecrafter47.bungeetablistplus.util.VelocityPlugin;
import com.google.inject.Inject;
import com.velocitypowered.api.event.PostOrder;
import com.velocitypowered.api.event.Subscribe;
import com.velocitypowered.api.event.proxy.ProxyInitializeEvent;
import com.velocitypowered.api.event.proxy.ProxyShutdownEvent;
Expand Down Expand Up @@ -75,8 +76,8 @@ public BootstrapPlugin(final ProxyServer proxy, final Logger logger, final @Data
this.metricsFactory = metricsFactory;
}

@Subscribe
public void onProxyInitialization(final ProxyInitializeEvent event) {
@Subscribe(order = PostOrder.EARLY)
public void onProxyInitializationEarly(final ProxyInitializeEvent event) {
if (Float.parseFloat(System.getProperty("java.class.version")) < 61.0) {
getLogger().error("§cBungeeTabListPlus requires Java 17 or above. Please download and install it!");
getLogger().error("Disabling plugin!");
Expand All @@ -88,6 +89,10 @@ public void onProxyInitialization(final ProxyInitializeEvent event) {
}
}
BungeeTabListPlus.getInstance(this).onLoad();
}

@Subscribe(order = PostOrder.LATE)
public void onProxyInitializationLate(final ProxyInitializeEvent event) {
BungeeTabListPlus.getInstance(this).onEnable();
// Metrics
metricsFactory.make(this, 24808);
Expand Down