Skip to content

fix(velocity): cancel modified packets #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CodeCrafter47 merged 2 commits into from
Apr 10, 2025
Merged

fix(velocity): cancel modified packets #768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf171dc
fix(velocity): cancel modified packets
Kowagirl Mar 26, 2025
7a2f506
chore: update minecraft-data-api submodule
Kowagirl Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion minecraft-data-api
Open in desktop
Submodule minecraft-data-api updated 1 files
+2 −2 velocity/src/main/java/de/codecrafter47/data/velocity/PlayerDataAccess.java
15 changes: 5 additions & 10 deletions velocity/src/main/java/codecrafter47/bungeetablistplus/protocol/PacketListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,29 +51,24 @@ protected void decode(ChannelHandlerContext ctx, MinecraftPacket packet, List<Ob
if (packet != null) {

PacketListenerResult result = PacketListenerResult.PASS;
boolean handled = false;

if (packet instanceof Team) {
result = handler.onTeamPacket((Team) packet);
if (result == PacketListenerResult.MODIFIED) {
sendPacket(player, packet);
}
} else if (packet instanceof LegacyPlayerListItemPacket) {
result = handler.onPlayerListPacket((LegacyPlayerListItemPacket) packet);
handled = true;
} else if (packet instanceof HeaderAndFooterPacket) {
result = handler.onPlayerListHeaderFooterPacket((HeaderAndFooterPacket) packet);
handled = true;
} else if (packet instanceof UpsertPlayerInfoPacket) {
result = handler.onPlayerListUpdatePacket((UpsertPlayerInfoPacket) packet);
handled = true;
} else if (packet instanceof RemovePlayerInfoPacket) {
result = handler.onPlayerListRemovePacket((RemovePlayerInfoPacket) packet);
handled = true;
}

if (handled && result != PacketListenerResult.CANCEL) {
sendPacket(player, packet);
if (result != PacketListenerResult.PASS) {
if (result == PacketListenerResult.MODIFIED) {
sendPacket(player, packet);
}
return;
}
}
}
Expand Down