feat: updated eslint, dependency upgrades#135
Merged
CodeDead merged 1 commit intodevelopmentfrom Apr 18, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ESLint configuration and upgrades various dependencies while cleaning up code formatting across multiple components. Key changes include:
- Refactored component imports and JSX formatting for consistency.
- Upgraded dependency versions (tauri, rand, etc.) and updated workflow configurations.
- Introduced a new ESLint configuration with updated linting rules.
Reviewed Changes
Copilot reviewed 44 out of 49 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/PasswordTips/index.jsx | Reformatted code and updated tip generation logic |
| src/components/LoadingBar/index.jsx | Minor JSX formatting adjustments |
| src/components/LinearProgressWithLabel/index.jsx | Updated import order to align with best practices |
| src/components/GridList/index.jsx | Consolidated props into a single destructuring pattern |
| src/components/EncryptionKeyDialog/index.jsx | Removed duplicate imports and cleaned up JSX |
| src/components/EditPasswordDialog/index.jsx | Reformatted state initialization and code style |
| src/components/CreatePasswordDialog/index.jsx | Cleaned up JSX and improved dependency imports |
| src/components/ClippedDrawer/index.jsx | Changed import order and revised drawer structure |
| src/components/App/index.jsx | Adjusted import ordering and JSX structure |
| src/components/AlertDialog/index.jsx | Simplified JSX formatting in dialog component |
| src-tauri/Cargo.toml | Upgraded tauri and rand dependencies |
| index.html | Changed DOCTYPE for consistency |
| eslint.config.js | Added a comprehensive ESLint configuration |
| .github/workflows/test.yml | Updated workflow configuration and dependency installs |
| .github/workflows/release.yml | Revised release workflow steps and build configurations |
Files not reviewed (5)
- .eslintignore: Language not supported
- .eslintrc.json: Language not supported
- .prettierignore: Language not supported
- .prettierrc: Language not supported
- package.json: Language not supported
Comments suppressed due to low confidence (2)
src/components/PasswordTips/index.jsx:45
- The condition is checking the ref object (intervalId) rather than its current property. Consider using 'intervalId.current !== null' to correctly determine if the interval is set.
return () => intervalId !== null ? clearInterval(intervalId.current) : null;
src/components/GridList/index.jsx:7
- The 'size' prop is not a standard prop for MUI's Grid component. Replace it by using the 'item' prop and passing breakpoint props (e.g., xs, md, lg) directly to ensure proper layout behavior.
<Grid key={i} size={{ xs, md, lg }}>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.