Conversation
…ith flex-shrink-0, to prevent future issues if the ui were to change around the icon.
…oved the UX. In addition to fixing mobile to close the sidebar by default.
Collaborator
Author
|
Added admin portal UI rework. |
taichan03
deleted the
282-standardize-icon-sizes-in-navigation-bar-in-the-admin-portal-medium
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sidebar does not change size when the logo is present, so I removed the breakpoint, keeping the logo the same size across all screen sizes. In addition the file Icon was being squished because of size of the div that was being truncated was the size of the container, which compressed it. I fixed the size of the container to the ideal point less that the parent size so there was room; it no longer shrinks.