Open
Conversation
carrollsa
commented
Feb 28, 2024
Comment on lines
+93
to
+99
| {shelterluvShortId && | ||
| <Grid item> | ||
| <IconButton style={{ 'padding': 0, 'paddingLeft': 5 }} color="primary" aria-label="link" href={shelterLuvPersonURL} target="_blank"> | ||
| <LinkIcon /> | ||
| </IconButton> | ||
| </Grid> | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
This is a link to shelterluv that just gives a 404 if the ID doesn't exist. I figured we didn't want to send people there.
carrollsa
commented
Feb 28, 2024
Comment on lines
-82
to
+73
| <HomeIcon color='primary' fontSize='small'/> | ||
| <PhoneIcon color='primary' fontSize='small'/> |
Collaborator
Author
There was a problem hiding this comment.
The diff is a little misleading here with how it rearranged things. I didn't change the icons. I only messed with whether things render or not depending on what data we have available for the contact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes