-
Notifications
You must be signed in to change notification settings - Fork 1
Changed casing, changed import helpers to false in tsconfig.json so imports can be handled as we see fit #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
soundparticle
wants to merge
9
commits into
CodeForPortland:master
Choose a base branch
from
soundparticle:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
99f3612
SigninForm ready for FormControl to be added
soundparticle 1c008db
added FormControl component
soundparticle f74c6c0
started adding CSS
soundparticle 818db5f
minor fixes
soundparticle ef9fb51
fixed casing on SignInForm
soundparticle 8fa0b42
grouped imports and changed tsconfig.json totrue for import helpers
soundparticle 33d6445
changes import helper in tsconfig.json to false
soundparticle 020c08b
Update login.component.tsx
soundparticle 4693795
Update SigninForm.js
soundparticle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| .form-boxes { | ||
| border-width: 2px; | ||
| border-color: steelblue; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| /* tslint:disable:no-empty */ | ||
| import FormControl from '../../shared/FormControl'; | ||
| import PropTypes from 'prop-types'; | ||
|
|
||
| import React, { PureComponent } from 'react'; | ||
|
|
||
| import './SignInForm.scss'; | ||
|
|
||
| export class SignInForm extends PureComponent { | ||
soundparticle marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| state = { | ||
| email: '', | ||
| password: '', | ||
| } | ||
|
|
||
| static propTypes = { | ||
| action: PropTypes.string.isRequired, | ||
| submit: PropTypes.func.isRequired, | ||
| } | ||
|
|
||
| handleSubmit = event => { | ||
| event.preventDefault(); | ||
| this.props.submit(this.state) | ||
| .catch(() => {}); | ||
| } | ||
|
|
||
| handleChange = ({ target }) => { | ||
| this.setState({ [target.email]: target.value }); | ||
| } | ||
|
|
||
| render() { | ||
| const { action } = this.props; | ||
| const { email, password } = this.state; | ||
|
|
||
| return ( | ||
| <form onSubmit={this.handleSubmit}> | ||
|
|
||
| <FormControl label="email"> | ||
| <input className="form-boxes" name="email" value={email} | ||
| onChange={this.handleChange}/> | ||
| </FormControl> | ||
|
|
||
| <FormControl label="password"> | ||
| <input className="form-boxes" name="password" value={password} type="password" | ||
| onChange={this.handleChange}/> | ||
| </FormControl> | ||
|
|
||
| <FormControl> | ||
| <button className="form-boxes">{action}</button> | ||
| </FormControl> | ||
| </form> | ||
| ); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import React, { PureComponent } from 'react'; | ||
|
|
||
| import PropTypes from 'prop-types'; | ||
|
|
||
| class FormControl extends PureComponent { | ||
|
|
||
| static propTypes = { | ||
| children: PropTypes.element, | ||
| label: PropTypes.string, | ||
| }; | ||
|
|
||
| render() { | ||
| const { label, children } = this.props; | ||
|
|
||
| return ( | ||
| <section> | ||
| { label && <label>{label}:</label> } | ||
| <section> | ||
| {children} | ||
| </section> | ||
| </section> | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| export default FormControl; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.