-
Notifications
You must be signed in to change notification settings - Fork 164
feats: extend ValuePool by new fields : files, and maxMutations #1033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Don't generate the same mutator for the same fuzz test method multiple times. Before this change, a mutator was generated for each crash file in fuzzing mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR extends the @ValuePool annotation to support two new capabilities: (1) loading files as byte arrays using glob patterns via a new files field, and (2) controlling mutation iterations via a new maxMutations field.
Changes:
- Added
filesfield to@ValuePoolannotation for glob-based file loading - Added
maxMutationsfield to control mutation iterations on pool values - Implemented file pattern matching and path resolution in
ValuePoolRegistry - Updated mutation logic to apply multiple mutations based on
maxMutations - Added caching for ArgumentsMutator instances and file reads
- Comprehensive test coverage for file loading feature
- Extensive documentation updates
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 16 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/com/code_intelligence/jazzer/mutation/annotation/ValuePool.java | Added files and maxMutations fields to annotation with documentation |
| src/main/java/com/code_intelligence/jazzer/mutation/support/ValuePoolRegistry.java | Implemented glob pattern matching, file loading, and maxMutations extraction with path resolution logic |
| src/main/java/com/code_intelligence/jazzer/mutation/mutator/lang/ValuePoolMutatorFactory.java | Updated mutate/crossOver to apply multiple mutations based on maxMutations |
| src/test/java/com/code_intelligence/jazzer/mutation/support/ValuePoolsTest.java | Added comprehensive tests for file loading patterns and updated test helpers |
| src/main/java/com/code_intelligence/jazzer/mutation/ArgumentsMutator.java | Added caching for ArgumentsMutator instances to improve performance |
| src/main/java/com/code_intelligence/jazzer/junit/FuzzTestExecutor.java | Set system property for baseDir to enable ValuePoolRegistry file resolution |
| docs/mutation-framework.md | Added extensive documentation for ValuePool features including examples and usage patterns |
Comments suppressed due to low confidence (1)
src/test/java/com/code_intelligence/jazzer/mutation/support/ValuePoolsTest.java:415
- The test helper withValuePoolImplementation is missing the maxMutations() method implementation. Since maxMutations() is now part of the @valuepool annotation interface, this anonymous implementation must override it. Without this method, using this test helper will result in runtime errors when the annotation's maxMutations() method is called.
return new ValuePool() {
@Override
public String[] value() {
return value;
}
@Override
public String[] files() {
return files;
}
@Override
public double p() {
return p;
}
@Override
public String constraint() {
return constraint;
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/com/code_intelligence/jazzer/mutation/support/ValuePoolRegistry.java
Outdated
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/mutation/annotation/ValuePool.java
Outdated
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/mutation/support/ValuePoolRegistry.java
Outdated
Show resolved
Hide resolved
src/test/java/com/code_intelligence/jazzer/mutation/support/ValuePoolsTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/mutation/mutator/lang/ValuePoolMutatorFactory.java
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/mutation/support/ValuePoolRegistry.java
Show resolved
Hide resolved
| @Override | ||
| public T mutate(T value, PseudoRandom prng) { | ||
| if (prng.closedRange(0.0, 1.0) < poolUsageProbability) { | ||
| if (prng.choice()) { | ||
| return prng.pickIn(userValues); | ||
| } else { | ||
| // treat the value from valuePool as a starting point for mutation | ||
| return mutator.mutate(prng.pickIn(userValues), prng); | ||
| value = prng.pickIn(userValues); | ||
| // Treat the user value as a starting point for mutation | ||
| for (int i = 0; i < prng.closedRange(0, maxMutations); i++) { | ||
| value = mutator.mutate(value, prng); | ||
| } | ||
| return value; | ||
| } | ||
| return mutator.mutate(value, prng); | ||
| } | ||
|
|
||
| @Override | ||
| public T crossOver(T value, T otherValue, PseudoRandom prng) { | ||
| return mutator.crossOver(value, otherValue, prng); | ||
| if (prng.closedRange(0.0, 1.0) < poolUsageProbability) { | ||
| value = prng.pickIn(userValues); | ||
| otherValue = prng.pickIn(userValues); | ||
| // Treat the user value as a starting point for crossOver | ||
| for (int i = 0; i < prng.closedRange(0, maxMutations); i++) { | ||
| value = mutator.crossOver(value, otherValue, prng); | ||
| } | ||
| return value; | ||
| } else { | ||
| return mutator.crossOver(value, otherValue, prng); | ||
| } | ||
| } |
Copilot
AI
Jan 21, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The maxMutations functionality in the mutate and crossOver methods lacks test coverage. Tests should verify that: (1) when a pool value is selected, mutations are applied up to maxMutations times, (2) the number of mutations is correctly randomized between 0 and maxMutations, and (3) the behavior works correctly with different maxMutations values including 0 and 1.
9a2818a to
16da4a3
Compare
The number of fields in ValuePool is getting large, so that construction using positional args is becoming confusing. Using a builder simplifies the tests.
9e344a7 to
ed09c59
Compare
- check of JVM is still alive before dumping the stack
ed09c59 to
e2cc773
Compare
e2cc773 to
42a3a15
Compare
42a3a15 to
6d874ba
Compare
@ValuePoolannotation by using the new fieldString[] files---files matching the patterns will be loaded asbyte []. The field uses theglob:syntax ofjava.nio.file.PathMatcher.Example:
maxMutations, the users can now control up to how many times (by default 1) values selected from@ValuePoolwill be mutated by the underlying mutator in one mutation operation.