all changes are done

Author: shaghayeghfar

Sprint-3/2-practice-tdd/count.js

@@ -1,12 +1,33 @@
 function countChar(stringOfCharacters, findCharacter) {
+  // stringOfCharacters and findCharacter both should be string.
   if (
     typeof stringOfCharacters !== "string" ||
     typeof findCharacter !== "string"
   ) {
-    return 0;
+    return "Values Can not be Numbers";
   }
+
+  // stringOfCharacters should be longer than findCharacter.
+  if (
+    stringOfCharacters.length !== 0 &&
+    findCharacter.length > stringOfCharacters.length
+  ) {
+    return "the stringOfCharacters MUST be lonegr than findingcharacter";
+  }
+
+  //stringOfCharacters shoud not be empty
+  if (stringOfCharacters.length === 0) {
+    return "stringOfCharacters can not be empty";
+  }
+
+  //findCharacter should not be empty
+  if (findCharacter.length === 0) {
+    return "findCharacter can not be empty";
+  }
+
+  // finscharatcter should be single character.
   if (findCharacter.length !== 1) {
-    return 0;
+    return "findCharacter must be a single character";
   }
 
   let count = 0;

Sprint-3/2-practice-tdd/count.test.js

@@ -63,45 +63,47 @@ test("should return 0 when the 'c' does not exist in string 'I dont have an appl
 // When the function is called,
 // Then it should return 0 because a multi-character string cannot match a single character position.
 
-test("should return 0 when findCharacter is longer than the input string", () => {
+test("should return a message  when findCharacter is longer than the input string", () => {
   const str = "a";
   const char = "abc";
   const count = countChar(str, char);
-  expect(count).toEqual(0);
+  expect(count).toEqual(
+    "the stringOfCharacters MUST be lonegr than findingcharacter"
+  );
 });
 
 // Scenario: Empty string input
 // Given an empty input string and a valid character,
 // When the function is called,
 // Then it should return 0 because there are no characters to search.
 
-test("should return 0 when input string is empty", () => {
+test("should return a Message  when input stringOfCharacters is empty", () => {
   const str = "";
   const char = "a";
   const count = countChar(str, char);
-  expect(count).toEqual(0);
-});
-
-// Scenario: Non-string input type
-// Given that one or both inputs are not strings (e.g., number, array),
-// When the function is called,
-// Then it should return 0 or handle the input gracefully without throwing an error.
-
-test("should return 0 when inputs are not strings", () => {
-  const str = 12345;
-  const char = 1;
-  const count = countChar(str, char);
-  expect(count).toEqual(0);
+  expect(count).toEqual("stringOfCharacters can not be empty");
 });
 
 // Scenario: Empty findCharacter
 // Given a valid string but an empty findCharacter,
 // When the function is called,
 // Then it should return 0 because an empty search target is not valid.
 
-test("should return 0 when findCharacter is an empty string", () => {
+test("should return message  when findCharacter is an empty string", () => {
   const str = "hello";
   const char = "";
   const count = countChar(str, char);
-  expect(count).toEqual(0);
+  expect(count).toEqual("findCharacter can not be empty");
+});
+
+// Scenario: Non-string input type
+// Given that one or both inputs are not strings (e.g., number, array),
+// When the function is called,
+// Then it should return 0 or handle the input gracefully without throwing an error.
+
+test("should return message when inputs are numbers", () => {
+  const str = 12345;
+  const char = 1;
+  const count = countChar(str, char);
+  expect(count).toEqual("Values Can not be Numbers");
 });

Sprint-3/2-practice-tdd/get-ordinal-number.js

@@ -1,7 +1,7 @@
 function getOrdinalNumber(number) {
   // Handle invalid inputs
   if (typeof number !== "number" || !Number.isFinite(number)) {
-    return "Invalid input";
+    return "Invalid input : Expected a infinit number";
   }
 
   // Handle zero or negative numbers (optional)

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

@@ -73,15 +73,19 @@ test("should return '23rd' for 23", () => {
 // Then the function should return "Invalid input"
 
 test("should return 'Invalid input' when input is undefined", () => {
-  expect(getOrdinalNumber(undefined)).toEqual("Invalid input");
+  expect(getOrdinalNumber(undefined)).toEqual(
+    "Invalid input : Expected a infinit number"
+  );
 });
 
 // Case null :
 // When the nymber is null ,
 // Then the function should return "Invalid input"
 
 test("should return 'Invalid input' when input is null", () => {
-  expect(getOrdinalNumber(null)).toEqual("Invalid input");
+  expect(getOrdinalNumber(null)).toEqual(
+    "Invalid input : Expected a infinit number"
+  );
 });
 
 // Case negetive number  :
@@ -97,5 +101,7 @@ test("should return '-1th' for -1", () => {
 // Then the function should return "Invalid input"
 
 test("should return 'Invalid input' when input is NaN", () => {
-  expect(getOrdinalNumber(NaN)).toEqual("Invalid input");
+  expect(getOrdinalNumber(NaN)).toEqual(
+    "Invalid input : Expected a infinit number"
+  );
 });