-
Notifications
You must be signed in to change notification settings - Fork 364
Pass in logger #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Pass in logger #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
6f5a61f to
5611b01
Compare
Refactored batch-str-replace.ts, stream-parser.ts, and api/agents.ts to pass logger as a parameter instead of importing it directly. Updated all callers including run-agent-step.ts and test files. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
933f6a6 to
f377c99
Compare
🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
1eb069d to
d81c330
Compare
Refactored the following files to accept logger as a parameter instead of importing it directly: - util/simplify-tool-results.ts: simplifyTerminalCommandResults now takes logger param - util/messages.ts: All message utility functions now accept logger param - util/check-auth.ts: checkAuth and checkAdmin refactored with logger param - util/quickjs-sandbox.ts: dispose methods now require logger param - Updated all callers in production code and test files - Updated plan documentation with clearer instructions for test logger naming 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
d81c330 to
518e3db
Compare
🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
…parameter 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
…ameter 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
…e ws into options object 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.