Skip to content

test mjs file #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dreamwasp merged 16 commits into from
Feb 10, 2025
Merged

test mjs file #187

dreamwasp merged 16 commits into from
Feb 10, 2025

Conversation

@dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Feb 6, 2025 •
edited
Loading

Release Notes

Adds .mjs file type to babel-loader type to properly load reach/ui + reach/tabs

PR Checklist

  • Related to JIRA ticket: cass-gm-1000
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • Need to check why alpha publish isn't working, tested locally and got it working through direct node_module edit

jakemhiller
jakemhiller approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@jakemhiller jakemhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dreamwasp dreamwasp marked this pull request as ready for review February 7, 2025 20:29
@dreamwasp dreamwasp requested a review from a team as a code owner February 7, 2025 20:29
@dreamwasp dreamwasp requested review from BandanaKM and aresnik11 and removed request for a team February 7, 2025 20:29
@dreamwasp dreamwasp added release/minor Increment the minor version when merged and removed release/minor Increment the minor version when merged labels Feb 7, 2025
@jakemhiller jakemhiller added release/patch Increment the patch version when merged Ship It :shipit: Automerge this PR when possible labels Feb 10, 2025
@dreamwasp dreamwasp merged commit 7ce8d04 into main Feb 10, 2025
10 of 11 checks passed
@dreamwasp dreamwasp deleted the cass-gm-1000 branch February 10, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakemhiller jakemhiller jakemhiller approved these changes

@BandanaKM BandanaKM Awaiting requested review from BandanaKM BandanaKM is a code owner automatically assigned from Codecademy/web-platform

@aresnik11 aresnik11 Awaiting requested review from aresnik11 aresnik11 is a code owner automatically assigned from Codecademy/web-platform

Assignees

No one assigned

Labels

release/patch Increment the patch version when merged Ship It :shipit: Automerge this PR when possible

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dreamwasp @jakemhiller