feat: use diatonic spelling instead of chromatic spelling #2534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: minor key signature handling for numbered notation
Danielku15
force-pushed
the
feature/diatonic-scale
branch
5 times, most recently
from
bc7e236 to
7416e08
Compare
Danielku15
force-pushed
the
feature/diatonic-scale
branch
from
7416e08 to
e7d0027
Compare
Danielku15
added a commit
that referenced
this pull request
Feb 1, 2026
(cherry picked from commit a821dd0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #2511
Proposed changes
This PR changes the whole note head steps and accidental calculation to respect diatonic scales compared to the previous chromatic placement.
The logic mainly uses pre-computed lookup tables to decide things.
Additionally this PR fixes some bits in the numbered notation around octave dots, accidentals, and key signatures (specifically minor key signatures).
The display should now be on-par with Guitar Pro an follow the general principles.
Checklist
Further details