Easier language implementation + Updated font #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ct-oregon-trail ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Rodak123
changed the title
Contributor
Author
|
The new font characters aren't the greatest, but they're good enough. |
Member
|
Wow, I don't know that I'll have the bandwidth to maintain a version of the game in multiple languages but this seems like a great approach regardless. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rampage64 added different languages in #45, by creating different
page_data.jsonfiles which might be hard to keep updating each time a new page is made or updated, so I added his translations into an easier system.Also language switching now works.