feat(sdk): auto-include imagemanifest and ContentManifest.json files #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .NET SDK auto-includes *.resx files as EmbeddedResource items. The VsixSdk also includes VSPackage.resx with special metadata (MergeWithCTO). This caused duplicate item errors. Fix by excluding VSPackage.resx patterns from DefaultItemExcludes so the SDK's explicit includes with MergeWithCTO metadata are the only ones.
CalvinAllen
force-pushed
the
feat/sdk/auto-include-imagemanifest
branch
from
442a435 to
dcc380a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.imagemanifestfiles asImageManifestitemsContentManifest.jsonfiles asContentitems withIncludeInVSIX=trueDetails
Image Manifests (
.imagemanifest)Used by the VS Image Service for custom images. Files are automatically included in the VSIX.
Content Manifests (
ContentManifest.json)Used for VS extension content registration. Files are included in VSIX and copied to output.
VSPackage.resx Fix
Excludes
VSPackage.resxpatterns fromDefaultItemExcludesto prevent duplicate EmbeddedResource items. The SDK adds these with specialMergeWithCTOmetadata.Properties
EnableDefaultImageManifestItems=false- Disable imagemanifest auto-includeEnableDefaultContentManifestItems=false- Disable ContentManifest.json auto-includeCloses #31