fix(sdk): exclude template folders from default compilation #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Template files contain VS template placeholders ($safeprojectname$, etc.) that are not valid C# and should not be compiled as part of the extension. This adds ProjectTemplates/** and ItemTemplates/** to DefaultItemExcludes.
CalvinAllen
deleted the
fix/sdk/exclude-template-folders-from-compilation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Exclude
ProjectTemplates/andItemTemplates/folders from default compilation.Problem
Template files contain VS template placeholders (
$safeprojectname$,$guid1$, etc.) that are not valid C# syntax. When these folders are in a VSIX project, the .NET SDK tries to compile them, causing build errors.Solution
Add the template folders to
DefaultItemExcludesinSdk.Vsix.Templates.props:This uses the configurable folder properties, so custom folder locations are also excluded.