fix(sdk): fix VsixTemplateReference path computation #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the metadata computation into two ItemGroup updates because MSBuild cannot reference metadata that is set in the same update. Step 1 computes _ReferencedProjectDir and _TemplateFolderName. Step 2 uses those values to compute _FullTemplatePath and zip info. Closes #37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the
VsixTemplateReferencepath computation bug that caused templates from referenced projects to fail zipping.Problem
MSBuild cannot reference metadata that is set in the same
ItemGroupupdate. The original code tried to set_ReferencedProjectDirand immediately use it to compute_FullTemplatePathin the same update, resulting in an empty/incorrect path.Solution
Split the metadata computation into two separate
ItemGroupupdates:_ReferencedProjectDirand_TemplateFolderName_FullTemplatePath,_ZipFileName, and_ZipOutputPathTesting
Verified locally that
VsixTemplateReferencenow correctly resolves paths like:instead of the broken:
Closes #37