Fix typo in exception message#636
Merged
lmajano merged 1 commit intoColdBox:developmentfrom Jan 3, 2026
Merged
Conversation
| } : {} | ||
| ) | ||
| .addMessage( "An exception ocurred: #arguments.exception.message#" ) | ||
| .addMessage( "An exception occurred: #arguments.exception.message#" ) |
There was a problem hiding this comment.
The error response exposes the raw arguments.exception.message directly to the client, which can leak internal details such as stack information, file paths, or database error messages. An attacker can intentionally trigger failures to harvest these messages and gain information useful for further attacks. Instead, return a generic, user-safe error message to clients and log the detailed exception message only on the server side.
Suggested change
| .addMessage( "An exception occurred: #arguments.exception.message#" ) | |
| .addMessage( "An unexpected error occurred while processing your request." ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simple typo fix