Open
Conversation
- Remove subclasses - Use supported API for spnego.client - Update some tests
Colin-b
reviewed
Aug 25, 2021
httpx_auth/authentication.py
Outdated
| httpx.BasicAuth.__init__(self, username, password) | ||
|
|
||
|
|
||
| class Negotiate(httpx.Auth, SupportMultiAuth): |
Owner
There was a problem hiding this comment.
Could you move everything to a specific file ?
added 12 commits
August 25, 2021 17:32
- Add a functional test - Update imports
- Add tests for redirect handling - Add test for setting cookies during auth process
|
Kudos, SonarCloud Quality Gate passed!
|
|
SonarCloud Quality Gate failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for most of the Negotiate and NTLM authentication mechanisms. No current support for Channel Binding Tokens, since it is currently not possible to access the httpx SSLSocketContext via supported means.
PR has been tested with IIS on Windows 10, but should be considered alpha, it has not been tested on any linux distributions.
PR includes unit tests for helper functions, but does not currently include any end-to-end tests, it should be possible to deploy a KDC and protected server in a container, but I have not implemented that so far.