#22_ActesSousTraitance #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Voici un code playground pour l'issue 22. Il fonctionne pour le fichier decp2019. Donnez moi votre avis sur son implémentation !!
Owner
|
Salut @ElyotL ! Merci pour ta PR ! Actuellement je ne suis pas sur les actes de sous-traitance, mais je la regarde bientôt. J'essaie de ne pas me disperser. J'y ai jeté un bref coup d'oeil : tu as utilisé Pandas alors que ce projet utilise Polars, une bibliothèque plus performante. Ce qui est sûr, c'est que si on utilise ton code, on devra le convertir à Polars. Si c'est déjà fait, c'est du temps de gagné ;) |
Collaborator
Author
|
Salut @ColinMaudry, voici ma nouvelle PR pour faire exactement la même chose mais avec polars. J'ai enlevé mes fonctions de test aussi. Dis moi ce que tu en penses ! |
ColinMaudry
force-pushed
the
main
branch
2 times, most recently
from
ed2ee3b to
2336711
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Voici un code playground pour l'issue 22. Il fonctionne pour le fichier decp2019. Donnez moi votre avis sur son implémentation c'est ma première PR