Save Idle CPU Cycles from SharpDiscordRPC

[neon-nyan]

Main Goal

This PR updates the RPC submodule which contains CPU cycles fix on idle. This switches the loop-based routine on reading RPC frames to timer-based routine. Both previous loop-based and new timer-based routine uses the same Poll rate for 1000ms each. We also switched the buffer allocation to rent-based buffer.

The difference between these two methods are, loop-based uses WaitHandleEvent to Sleep on background threads with endless loop routine, thus continuously wasting thread time on each poll rate (every 1000ms) while performing RPC update. Timer-based routine instead, uses Timer to trigger the RPC update on each poll rate (every 1000ms) and will end the thread once it's done.

The behavior shouldn't be affected as it only switching the loop routine with timer and the poll rate for frame reading is still the same.

PR Status :

• Overall Status : Done
• Commits : Done
• Synced to base (Collapse:main) : Yes
• Build status : OK
• Crashing : No
• Bug found caused by PR : 2 (per commented)

Templates

Changelog Prefixes

  **[New]**
  **[Imp]**
  **[Fix]**
  **[Loc]**
  **[Doc]**

[neon-nyan]

@sentry review

[bagusnl]

Need check behavior on arrpc based clients.
Will do

[bagusnl]

arrpc client works

[bagusnl]

Bug found

1. RPC fails to reconnect on Discord client restart. Both in arrpc and official client

Repro step:
Start Discord -> Start Collapse -> Stop Discord -> Observe log -> start Discord -> Observe log -> Switch Collapse pages (do not switch Game/region)

3. Stuck client did not get disposed/cleared on game switch

Repro step:
Start Discord -> Start Collapse -> Stop Discord -> Observe log -> start Discord -> Observe log -> Switch Collapse game

[neon-nyan]

@bagusnl The issue mentioned above should have been fixed with the commit above. Can you confirm it at your end?