Skip to content

add try-catch to ensure release of http resource #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shokakucarrier merged 2 commits into from
Mar 11, 2025
Merged

add try-catch to ensure release of http resource #37

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a553db
add try-catch to ensure release of http resource
shokakucarrier Feb 5, 2025
661859e
replace try with try-with-resource
shokakucarrier Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion .../client-java/src/main/java/org/commonjava/indy/folo/client/IndyFoloAdminClientModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,21 @@ public TrackingIdsDTO getTrackingIds( final String trackingType )
public void deleteFilesFromStoreByTrackingID( final BatchDeleteRequest request )
throws IndyClientException
{
http.postRaw( UrlUtils.buildUrl( "/folo/admin/batch/delete" ), request );
String url = UrlUtils.buildUrl("/folo/admin/batch/delete");
HttpResources resources = null;
try
{
resources = http.postRaw(url, request);
if (resources.getStatusCode() != HttpStatus.SC_OK)
{
throw new IndyClientException( resources.getStatusCode(), "Error deleting files: %s",
new IndyResponseErrorDetails( resources.getResponse() ) );
}
}
finally
{
IOUtils.closeQuietly( resources );
}
Copy link
Member

@ligangty ligangty Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to recommend to use try(resource) instead of this finally.

    String url = UrlUtils.buildUrl("/folo/admin/batch/delete");
    try (HttpResources resources = http.postRaw( url, request ))
    {
        if ( resources.getStatusCode() != HttpStatus.SC_OK )
        {
            throw new IndyClientException( resources.getStatusCode(), "Error deleting files: %s",
                                           new IndyResponseErrorDetails( resources.getResponse() ) );
        }
    }

Copy link
Member Author

@shokakucarrier shokakucarrier Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I'll make a change

Copy link
Member Author

@shokakucarrier shokakucarrier Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ligangty I've changed it and there is nothing more that I can enhance

}

@Deprecated
Expand Down