Skip to content

Prevent people from pinging @channel #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MeMyselfMirai wants to merge 2 commits into
base: develop
Choose a base branch
from
+4 −0
Open

Prevent people from pinging @channel #387

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7b90b5
Prevent people from pinging @channel by submitting a Major Project wi…
MeMyselfMirai Nov 19, 2023
1f43a32
Oh wait, it's not an @ sign
MeMyselfMirai Nov 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions conditional/blueprints/major_project_submission.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,10 @@ def submit_major_project(user_dict=None):
return jsonify({"success": False}), 400
project = MajorProject(user_dict['username'], name, description)

# Don't you dare try pinging @channel
if "<!" in name:
name = "<! ".join(name.split("<!"))
Copy link
Contributor

@Qelxiros Qelxiros Dec 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just use .replace()?

Copy link
Contributor

@shaeespring shaeespring Dec 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is .replace() better than splitting it?

Copy link
Contributor

@shaeespring shaeespring Dec 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my mind, it accomplishes the same thing. What do you recommend changing it to that doesn't delete the evidence of their attempt to mass ping

Copy link
Contributor

@Qelxiros Qelxiros Dec 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does the same thing in that you get the same string at the end. However, replace expresses the intent better, and it probably runs faster because the C is optimized for this use case.


username = user_dict['username']
send_slack_ping({"text":f"<!subteam^S5XENJJAH> *{get_member_name(username)}* ({username})"
f" submitted their major project, *{name}*!"})
Expand Down