Skip to content

Speedup pt 2#469

Open
BigSpaceships wants to merge 6 commits intodevelopfrom
speedup-pt-2
Open

Speedup pt 2#469
BigSpaceships wants to merge 6 commits intodevelopfrom
speedup-pt-2

Conversation

@BigSpaceships
Copy link
Contributor

What

Changed database to use uids as indicies for attendance to speed up queries
Optimized ldap of member management
Changed all the group detection to use user_dict with groups from odic instead of ldap

Why

Conditional is still probably slow

Test Plan

  • Make sure member management still looks right
  • Make sure you can only access tabs you should
    • We should get financials and evals to make sure all their pages work (or impersonate)

Env Vars

No

Checklist

  • Tested all changes locally

Dockerfile Outdated
EXPOSE ${PORT}

COPY conditional /opt/conditional/conditional
COPY migrations /opt/conditional/migrations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why copy migrations in for production builds?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly because it lets you run the migrations in the docker container which makes things a lot easier, now that I think about it, we could just mount the migrations folder in the compose for developing

If you try and run them locally in a venv you have to change the database url since it is setup to work in a docker network which is why I did this originally

TLDR: I'm gonna mount it with the compose file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments