Open
Conversation
tallen42
requested changes
Feb 20, 2026
Dockerfile
Outdated
| EXPOSE ${PORT} | ||
|
|
||
| COPY conditional /opt/conditional/conditional | ||
| COPY migrations /opt/conditional/migrations |
Contributor
There was a problem hiding this comment.
Why copy migrations in for production builds?
Contributor
Author
There was a problem hiding this comment.
Mostly because it lets you run the migrations in the docker container which makes things a lot easier, now that I think about it, we could just mount the migrations folder in the compose for developing
If you try and run them locally in a venv you have to change the database url since it is setup to work in a docker network which is why I did this originally
TLDR: I'm gonna mount it with the compose file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Changed database to use uids as indicies for attendance to speed up queries
Optimized ldap of member management
Changed all the group detection to use user_dict with groups from odic instead of ldap
Why
Conditional is still probably slow
Test Plan
Env Vars
No
Checklist