Add SQL_ENCRYPT flags and keep MCP stdio JSON-clean #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary\n- add SQL_ENCRYPT / TRUST_SERVER_CERTIFICATE env flags (default encrypt=true) and apply across SQL/Windows/AAD auth\n- route logs to stderr to keep MCP stdio pure JSON\n\n## Why\n- Synapse/Azure SQL require encryption; SQL/Windows paths were hard-coded to encrypt=false with no env override, causing connection failures unless code is patched\n- stdout logging breaks MCP stdio (JSON parse errors); stderr keeps transport clean\n\n## Notes\n- README documents new envs