Create test.yml #2048
Closed
Create test.yml #2048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
As you can see, the fix works when you use the correct wasmvm version that includes the fix. |
Contributor
Author
|
Indeed. Sorry I forgot to close this :) It totally does work and that's super gday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the pointer issue is not resolved, so I absolutely must, in the strongest possible terms, urge you to merge this pull request because the issue is still there.
For these tests, passing 95% of the time should be treated as passing 0% of the time.
note
I noticed that the references came from wasmvm. So I am making this PR be the actual test, and it will use the latest wasmvm from
main.If this runs the test incorrectly, please let me know.
Frankly, I don't trust wasmvm, and never have, due to its use of cgo, which is nigh on impossible to debug.