[core] Fix period calculation #7230
Merged
+16
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in period calculation logic within the countly.common.js module. The issue was in how certain date/period strings were being marked as invalid.
Changes:
- Fixed incorrect use of
.replace()method ingetUniqArrayandgetUniqCheckArrayfunctions that was performing substring replacement instead of exact value replacement - Updated CHANGELOG to document the fix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| api/lib/countly.common.js | Fixed bug in 4 locations where .replace(key, 0) was incorrectly performing substring replacement; changed to use strict equality check with direct assignment to '0' |
| CHANGELOG.md | Added entry documenting the fix for getuniqarray and getuniqcheckarray functions |
mrmeghana
approved these changes
Jan 28, 2026
Cookiezaurs
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.