Potential fix for code scanning alert no. 12: DOM text reinterpreted as HTML #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as HTML Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Dhruva Shaw <dhruvashaw@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Creatrix-Net/creatrix-net.github.io/security/code-scanning/12
To fix the issue, the text extracted from
el.textContentshould be properly escaped before being inserted into the DOM as HTML. This ensures that any special characters in the text are treated as literal text rather than HTML or JavaScript. The best approach is to use a library or utility function to encode the text for safe HTML output.Steps to fix:
titleinto thenewLinestring with an escaped version oftitle.<,>,&,",') with their corresponding HTML entities.innerHTMLis escaped.Suggested fixes powered by Copilot Autofix. Review carefully before merging.