Address prealloc lint issues #4390
Merged
+34
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dsessler7
reviewed
Jan 22, 2026
Comment on lines
+407
to
408
| configs = append(configs, dataSource.ClusterName, dataSource.RepoName) | ||
| configs = append(configs, dataSource.Options...) |
Collaborator
There was a problem hiding this comment.
Suggested change
| configs = append(configs, dataSource.ClusterName, dataSource.RepoName) | |
| configs = append(configs, dataSource.Options...) | |
| configs = append(configs, dataSource.ClusterName, dataSource.RepoName, dataSource.Options...) |
Contributor
Author
There was a problem hiding this comment.
Since the first two elements being appended are strings and the last one is a string slice utilizing a variadic spread , you unfortunately can't do this in a single append call.
dsessler7
reviewed
Jan 22, 2026
Comment on lines
+411
to
412
| configs = append(configs, cloudDataSource.Stanza, cloudDataSource.Repo.Name) | ||
| configs = append(configs, cloudDataSource.Options...) |
Collaborator
There was a problem hiding this comment.
Suggested change
| configs = append(configs, cloudDataSource.Stanza, cloudDataSource.Repo.Name) | |
| configs = append(configs, cloudDataSource.Options...) | |
| configs = append(configs, cloudDataSource.Stanza, cloudDataSource.Repo.Name, cloudDataSource.Options...) |
dsessler7
approved these changes
Jan 22, 2026
Collaborator
dsessler7
left a comment
dsessler7
left a comment
There was a problem hiding this comment.
Couple nitpicks, but looks good to me.
Issue: PGO-2844
tjmoore4
force-pushed
the
prealloc-lint-fix
branch
from
dd46d95 to
041a047
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the new behavior (if this is a feature change)?
This update addresses prealloc lint issues.
Other Information:
Issue: PGO-2844