Skip to content

Conversation

@IceOfWraith
Copy link
Collaborator

This adds the port for the API to function on.

@IceOfWraith IceOfWraith requested a review from Greelan May 27, 2024 03:07
Copy link
Collaborator

@Greelan Greelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this actually work for existing instances that don't have the API port allocated - will the manifest cause "$APIPort" literally, or some other invalid value, to be put in the server config file?

@IceOfWraith
Copy link
Collaborator Author

I don't expect it to work on existing ones, no. I mentioned that in the development channel.

@Greelan
Copy link
Collaborator

Greelan commented May 27, 2024

Won't it break existing instances where someone is trying to configure it manually? Because it will always overwrite what they have included

@IceOfWraith
Copy link
Collaborator Author

This is a very undocumented feature of V Rising. So it will be extremely minimal and can be addressed on a case by case.

Copy link
Collaborator

@Greelan Greelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with caveat

@IceOfWraith
Copy link
Collaborator Author

I'm going to have to do some thought into this one. Might have to wait until Port refresh logic is hashed out. It doesn't "break" the game server fully, but it does remove the line from the config since it's blank.

@IceOfWraith IceOfWraith marked this pull request as draft June 6, 2024 18:26
@IceOfWraith IceOfWraith deleted the vrisingport branch September 30, 2024 07:05
@IceOfWraith IceOfWraith restored the vrisingport branch September 30, 2024 07:14
@IceOfWraith IceOfWraith reopened this Sep 30, 2024
@IceOfWraith IceOfWraith closed this Jan 7, 2025
@IceOfWraith IceOfWraith deleted the vrisingport branch January 7, 2025 22:20
@IceOfWraith IceOfWraith restored the vrisingport branch January 7, 2025 22:20
@IceOfWraith IceOfWraith reopened this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants