simplify the allocator #5601
Merged
simplify the allocator #5601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
current code has three different allocator functions, the generic one, one labeled "nodel" and one labeled "noassign" the `noassign` allocator just mimics the behavior of the basic one when the type in question is not copy-assignable and is only being used for types that are not copy-assignable so the default allocator will work _exactly_ the same anyway the `nodel` version is entirely unused thus, this PR removes the `nodel` and `noassign` versions and folds `try_assign` into the allocator so that all the logic is in one place also add in-code documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current code has three different allocator functions, the generic one, one labeled
nodeland one labelednoassignthe
noassignallocator just mimics the behavior of the basic one when the type in question is not copy-assignable, and is only being used for types that may not be copy-assignable, and so in those cases the default allocator will work exactly the same anyway, and sonoassignis wholly redundant. iircnoassignwas introduced to deal with types that aren't copy-assignable, but the logic in the regular allocator handles that anywaymeanwhile, the
nodelversion is entirely unused, and i can't find any history of what it was ever intended to be used forthus, this PR removes the
nodelandnoassignversions (nodelfor being unused, andnoassignfor being redundant), and foldstry_assigninto the allocator so that all the logic is in one placealso add in-code documentation