try to cleanup unused includes from headers #5629
Merged
+21
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Of course, that did very little to actually help build times. |
Member
gcc's libc++ has a lot of cross-includes such that including one header often pulls in dozens of others. MSTL does this too, but not as much, and with different headers. Obviously neither behavior can or should be relied on. |
Contributor
Author
|
It was actually the linters I was referring to (namely clangd), and I think it was the templates it was struggling with. |
ab9rf
approved these changes
Nov 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll see how this goes.
gcc/clang has been lying to me. Seems standard types like std::string don't require an #include in my version.