Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to DFHack that enables it to produce crashlogs (on Linux only) upon the majority of crashes (specifically ignoring those that occur post-shutdown).
There are a few topics I wish to address before considering it ready:
BT_ENTRY_MAXcan be any arbitrary value, is 25 lines a good limit, or should it be higher?As the implementation stands, I think the only possible hang would be if file io stalled whilst writing the crashlog. The crashlogs include a header that aims to make it clear these logs are produced by dfhack and not the vanilla game, which should hopefully prevent confusion.
An example generated crashlog is as follows: