Order search filter

[unboundlopez]

order-search-filter

This overlay adds a small filter field to the Work Orders screen. Typing text filters the existing manager order list so only matching entries remain visible.

Overlay
When the Work Orders screen is open, press Alt+S to focus the filter field. As you type, the list of work orders updates to show only the matching entries. Clearing the filter restores the full list.

[unboundlopez]

pre-commit.ci autofix

[ab9rf]

Is this redundant with DFHack/dfhack#5677?

[unboundlopez]

Is this redundant with DFHack/dfhack#5677?

I don’t know, possibly I use AI for all the code and the little knowledge I have to troubleshoot, but I don’t know what I’m doing. I’m just glad it ran.

I would love the scripts to be taken over by a professional if they like what they see.

[chdoc]

I took a look at this, and what I am seeing scares me. The tool implements filtering by (temporarily) deleting work orders from df.global.world.manager_orders.all. This is a very dangerous reproach, since any error in the code, be it now or in the future, could lead to work orders not being restored and subsequently lost.

While the potential user experience offered by this tool could be a significant improvement over DFHack/dfhack#5677 (which it takes the safe approach of only highlighting matching work orders instead of removing those that are not matching), I do not know the intricacies of the input handling of the widget system well enough to verify that all orders are successfully restored in every possible case. By his own admission, @unboundlopez also doesn't know the intricacies of the implementation.

It is my opinion that code of such a dangerous nature would need to be designed, written, explained, documented, and reviewed by an expert. None of that is the case here. Consequently, I estimate the effort required to ensure that this is safe to be comparable to writing this from scratch.

Hence I would suggest to not pursue this further at the current time.